Add ability to show additional questions #18

bartjkdp · 2024-10-18T11:59:43Z

Todo

Inplement support for different field types (CheckboxInput, PlainText, RadioInput, TextInput, TextareaInput)
Implement validation (required, maxLength)
Use main and sub category from global state
Wire up with react-hook-form
Save when creating a signal

The ifOneOf and ifAllOf setting is currently "out of scope"

More documentation on additional questions structure can be found here:
https://github.com/Amsterdam/signals-frontend/blob/main/docs/additional-questions.md

Closes #5

…stions

vercel · 2024-10-22T13:56:46Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
signalen-frontend-wcag	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 24, 2024 2:38pm

…stions # Conflicts: # src/app/[locale]/incident/add/components/IncidentQuestionsLocationForm.tsx

…etup

…ops to field

…d set chosen radio inputs back to chosen input

…o feat/5-additional-questions # Conflicts: # src/components/ui/RadioGroup.tsx

justiandevs · 2024-10-24T13:48:26Z

I have completed everything required, but there are still a few things that need to be addressed (in other pull requests, to keep this one from becoming too large).

The AssetSelect type question needs to be implemented (#7).
The LocationSelect type question needs to be implemented (#37).
Styling and accessibility are not included in this PR, as it focuses solely on the technical background work. We're waiting for the integration of NL Design System components (#38).
The possibility of a hard stop needs to be added (#36).
Conditional questions need to be implemented (#6).

This PR is best tested with a report for "Vuurwerkoverlast" (fireworks nuisance).

src/app/[locale]/incident/add/components/questions/TextInput.tsx

src/app/[locale]/incident/add/components/questions/PlainText.tsx

Robbert · 2024-10-24T20:33:24Z

@justiandevs Willen we iets van test automatisering toevoegen hier? Met vitest of playwright?

justiandevs · 2024-10-25T08:51:33Z

@justiandevs Willen we iets van test automatisering toevoegen hier? Met vitest of playwright?

Ik denk het wel. Hier wil ik alleen mee wachten totdat ook sowieso ifOneOf of ifAllOf functionaliteit is ingebouwd, dat zorgt voor de complexere situaties die goed doortest moeten worden, dan bouw ik dat in een keer.

bartjkdp and others added 2 commits October 18, 2024 13:58

feat: add ability to show additional questions

6aafe40

Merge remote-tracking branch 'origin/main' into feat/5-additional-que…

df9bcb3

…stions

vercel bot had a problem deploying to Preview – signalen-frontend-wcag October 22, 2024 13:57 Failure

justiandevs added 2 commits October 23, 2024 12:53

Merge remote-tracking branch 'origin/main' into feat/5-additional-que…

155407d

…stions # Conflicts: # src/app/[locale]/incident/add/components/IncidentQuestionsLocationForm.tsx

Feat: technical setup for dynamic loading of questions, radio group s…

e7a8da5

…etup

vercel bot deployed to Preview – signalen-frontend-wcag October 23, 2024 16:49 View deployment

justiandevs added 2 commits October 23, 2024 19:02

Refactor: add TODO comment for removal of hardcoded marker, rename pr…

5ee9f8a

…ops to field

Feat: add radio group answers to API post signal call

1769eba

vercel bot deployed to Preview – signalen-frontend-wcag October 23, 2024 17:29 View deployment

justiandevs added 2 commits October 23, 2024 19:54

Feat: add extra_properties type to FormStoreState type, on page reloa…

2807880

…d set chosen radio inputs back to chosen input

Feat: add extra_properties type to FormStoreState type, on page reloa…

7980a30

…d set chosen radio inputs back to chosen input

vercel bot deployed to Preview – signalen-frontend-wcag October 23, 2024 17:55 View deployment

Merge remote-tracking branch 'origin/feat/5-additional-questions' int…

a129298

…o feat/5-additional-questions # Conflicts: # src/components/ui/RadioGroup.tsx

vercel bot deployed to Preview – signalen-frontend-wcag October 23, 2024 17:57 View deployment

Fix: add extra check to decide if extra_properties exist

a354cc7

vercel bot deployed to Preview – signalen-frontend-wcag October 23, 2024 17:59 View deployment

Feat: add next prefetching

b1c5656

vercel bot deployed to Preview – signalen-frontend-wcag October 23, 2024 18:08 View deployment

justiandevs added 2 commits October 24, 2024 11:19

Feat: type assertion fix

48f735c

Feat: TextField integration for dynamic form

4442f03

vercel bot deployed to Preview – signalen-frontend-wcag October 24, 2024 10:22 View deployment

Feat: getValidators() function for react-hook-form

5682921

vercel bot deployed to Preview – signalen-frontend-wcag October 24, 2024 11:08 View deployment

Feat: show not required text in label if field is not required

d5c2217

vercel bot deployed to Preview – signalen-frontend-wcag October 24, 2024 11:27 View deployment

Feat: CheckboxInput for dynamic form

f68a53b

vercel bot deployed to Preview – signalen-frontend-wcag October 24, 2024 12:44 View deployment

Refactor: move dynamic render field related code out of form

74d8bdf

vercel bot deployed to Preview – signalen-frontend-wcag October 24, 2024 13:06 View deployment

Feat: add subtitle to CheckBoxInput and RadioInput

0c1cb10

vercel bot deployed to Preview – signalen-frontend-wcag October 24, 2024 13:10 View deployment

Feat: add TextAreaInput to dynamic form

213ca65

vercel bot deployed to Preview – signalen-frontend-wcag October 24, 2024 13:16 View deployment

Feat: add PlainText field to Dynamic form

fdb4b62

vercel bot deployed to Preview – signalen-frontend-wcag October 24, 2024 13:41 View deployment

Chore: remove unnecessary TODO comment

5bcd39e

justiandevs self-assigned this Oct 24, 2024

vercel bot deployed to Preview – signalen-frontend-wcag October 24, 2024 13:50 View deployment

justiandevs assigned bartjkdp Oct 24, 2024

justiandevs requested review from a team and Robbert October 24, 2024 13:51

justiandevs marked this pull request as ready for review October 24, 2024 13:51

justiandevs removed the request for review from a team October 24, 2024 13:51

Refactor: rename key to value in array of filter values

4bd87ae

vercel bot deployed to Preview – signalen-frontend-wcag October 24, 2024 14:38 View deployment

Robbert reviewed Oct 24, 2024

View reviewed changes

src/app/[locale]/incident/add/components/questions/TextInput.tsx Show resolved Hide resolved

src/app/[locale]/incident/add/components/questions/PlainText.tsx Show resolved Hide resolved

Robbert approved these changes Oct 24, 2024

View reviewed changes

Robbert merged commit ea67bc3 into main Oct 25, 2024
3 checks passed

Robbert deleted the feat/5-additional-questions branch October 25, 2024 11:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ability to show additional questions #18

Add ability to show additional questions #18

bartjkdp commented Oct 18, 2024 •

edited by justiandevs

Loading

vercel bot commented Oct 22, 2024 •

edited

Loading

justiandevs commented Oct 24, 2024

Robbert commented Oct 24, 2024

justiandevs commented Oct 25, 2024

Add ability to show additional questions #18

Add ability to show additional questions #18

Conversation

bartjkdp commented Oct 18, 2024 • edited by justiandevs Loading

vercel bot commented Oct 22, 2024 • edited Loading

justiandevs commented Oct 24, 2024

Robbert commented Oct 24, 2024

justiandevs commented Oct 25, 2024

bartjkdp commented Oct 18, 2024 •

edited by justiandevs

Loading

vercel bot commented Oct 22, 2024 •

edited

Loading